After having seen this kind of question several times, I think it could be interesting to start creating a small ‘series of rpmlint errors and their typical fixes”.<\/p>\n
Interested in it? So welcome to part #1 (this issue). The “series” is not really fledged out, but I will try to write post for various errors \/ topics, as they come along. Just drop me a note with an error you have seen \/ experienced in OBS while building a package.<\/p>\n
So what does it mean, if OBS tells you this:
\nExpression compares a char* pointer with a string literal. Usually a strcmp() was intended by the programmer<\/p>\n
Let’s have a look at a very simple C program, to show the issue: int main() { \n$ gcc test1.c -Wall So, even though we had such an easy program, line 6 seems to be an issue for us:<\/p>\n if (mytext == “Help”) {<\/p><\/blockquote>\n The issue, as simple as it may sound, is the comparison of a pointer (char *) with a literal (“Help”).<\/p>\n So how do we fix it? It involves changing the code, thus writing a patch (there are many good helps around for this… I won’t dive into patching here).. Of course, after having written a patch, be a good downstream, send it upstream!
\n#include <stdio.h><\/p>\n
\n char *mytext;
\n mytext = \"Help\";
\n if (mytext == \"Help\") {
\n printf(\"This should raise a warning\");
\n }
\n return 0;
\n}<\/code>Trying to compile this very simple C program, which on first sight many would probably say this is correct, will result in this:<\/p>\n
\ntest1.c: In function \u2018main\u2019:
\ntest1.c:6:14: warning: comparison with string literal results in unspecified behavior\n<\/p><\/blockquote>\n
\nWhat you want to do here is to replace this comparison with strcmp (just as OBS’ error message implied).
\nLook at this code now:
\n#include <stdio.h>
\n#include <string.h><\/p>\n